stop using python semver parsing for mysql versions #11868
Merged
+57
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We were using
packaging.parse
to compare mysql server versions, which broke when0.23.0
was released with dropped support forLegacyVersion
.This rolls our own custom version compares to find minimum supported versions, which is tolerant of non semver compliant version strings.
The regex parses all the numeric values, and does tuple int comparisons.
Reported in #11794
Reference links:
pypa/packaging#407
How I Tested These Changes
Added some test cases that override the server version string to exercise the parsing logic.